[SPARK-51252][SS][TESTS] Make tests more consistent for StateStoreInstanceMetricSuite #50405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
changed the title
HeartSaVioR
approved these changes
Mar 26, 2025
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1
Thanks for the quick fix!
Contributor
|
I'll merge this tomorrow to give others a chance to review it and leave any major comment. |
ericm-db
approved these changes
Mar 26, 2025
Contributor
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-51252
Fix for flaky tests described in #50030.
This PR relaxes the version check in the tests and processes more data in queries to force more batches.
I also reduced the number of shuffle partitions for one of the join queries because there used to be 5 * 4 state stores that would need a snapshot to upload in a short time span. Now there's only 3 * 4 stores to deal with.
Why are the changes needed?
The tests previously introduced in #50030 are quite flaky depending on the environment, resulting in CI gates failing some tests in the suite.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Re-ran and verified the tests multiple times locally, but primarily using the current merge gates to see if these pass properly.
Was this patch authored or co-authored using generative AI tooling?
No.