Skip to content

[SQL][SPARK-51635] Merge PushProjectionThroughLimit and PushProjectionThroughOffset#50431

Closed
Pajaraja wants to merge 1 commit intoapache:masterfrom
Pajaraja:pavle-martinovic_data/migratingpushprojectionthroughoffset
Closed

[SQL][SPARK-51635] Merge PushProjectionThroughLimit and PushProjectionThroughOffset#50431
Pajaraja wants to merge 1 commit intoapache:masterfrom
Pajaraja:pavle-martinovic_data/migratingpushprojectionthroughoffset

Conversation

@Pajaraja
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Code refactoring. Merging the PushProjectionThroughLimit and PushProjectionThroughOffset optimizer rules into one PushProjectionThroughLimitAndOffset rule.

Why are the changes needed?

Cleaner code.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Merged PushProjectionThroughLimitSuite and PushProjectionThroughOffsetSuite into PushProjectionThroughLimit And OffsetSuite, and ran those tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@Pajaraja Pajaraja changed the title [SQL][Minor] Merge PushLimitThroughLimit and PushLimitThroughOffset [SQL][Minor] Merge PushProjectionThroughLimit and PushProjectionThroughOffset Mar 27, 2025
@Pajaraja Pajaraja changed the title [SQL][Minor] Merge PushProjectionThroughLimit and PushProjectionThroughOffset [SQL][SPARK-51635] Merge PushProjectionThroughLimit and PushProjectionThroughOffset Mar 27, 2025
@cloud-fan
Copy link
Copy Markdown
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 10ecd55 Mar 27, 2025
Copy link
Copy Markdown
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants