[SPARK-51958][CORE][SQL][TESTS] Replace hardcoded icu version with c.ibm.icu.util.VersionInfo.ICU_VERSION it tests#50764
Closed
LuciferYang wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
LuciferYang
changed the title
com.ibm.icu.util.VersionInfo.ICU_VERSION it testsc.ibm.icu.util.VersionInfo.ICU_VERSION it tests
HyukjinKwon
approved these changes
Apr 30, 2025
zhengruifeng
approved these changes
Apr 30, 2025
dongjoon-hyun
approved these changes
Apr 30, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Contributor
Author
|
Thanks @dongjoon-hyun @HyukjinKwon and @zhengruifeng |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
….ibm.icu.util.VersionInfo.ICU_VERSION` it tests ### What changes were proposed in this pull request? This pr replace hardcoded icu version with `com.ibm.icu.util.VersionInfo.ICU_VERSION` in `CollationFactorySuite` and `CollationSuite`. ### Why are the changes needed? Avoid manually modifying hardcoded version in tests when upgrading the ICU. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Acitons ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50764 from LuciferYang/CollationFactorySuite-version. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr replace hardcoded icu version with
com.ibm.icu.util.VersionInfo.ICU_VERSIONinCollationFactorySuiteandCollationSuite.Why are the changes needed?
Avoid manually modifying hardcoded version in tests when upgrading the ICU.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No