Skip to content

[SPARK-52569][SQL] Fix the class cast exception in SecondsOfTimeWithFraction #51270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 1 commit into from
Closed

[SPARK-52569][SQL] Fix the class cast exception in SecondsOfTimeWithFraction #51270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,20 +317,21 @@ object HourExpressionBuilder extends ExpressionBuilder {
case class SecondsOfTimeWithFraction(child: Expression)
extends RuntimeReplaceable
with ExpectsInputTypes {

override def replacement: Expression = {

val precision = child.dataType match {
case TimeType(p) => p
case _ => TimeType.MIN_PRECISION
}
StaticInvoke(
classOf[DateTimeUtils.type],
DecimalType(8, 6),
"getSecondsOfTimeWithFraction",
Seq(child, Literal(precision)),
Seq(child.dataType, IntegerType))
}
private val precision: Int = child.dataType.asInstanceOf[TimeType].precision
Copy link
Copy Markdown
Member Author

@MaxGekk MaxGekk Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This val is initialized before the invoke of inputTypes(), so, asInstanceOf[TimeType] can fail on other types.


override def inputTypes: Seq[AbstractDataType] =
Seq(TimeType(precision))
Seq(TypeCollection(TimeType.MIN_PRECISION to TimeType.MAX_PRECISION map TimeType.apply: _*))

override def children: Seq[Expression] = Seq(child)

Expand Down
2 changes: 2 additions & 0 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ class TimeExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
checkEvaluation(
SecondsOfTimeWithFraction(Literal.create(null, TimeType(TimeType.MICROS_PRECISION))),
null)
assert(SecondsOfTimeWithFraction(Literal.create(null)).inputTypes.nonEmpty)

checkConsistencyBetweenInterpretedAndCodegen(
(child: Expression) => SecondsOfTimeWithFraction(child).replacement,
TimeType())
Expand Down