[SPARK-52600][CONNECT] Move CompletionIterator to common/utils#51311
Closed
huanliwang-db wants to merge 1 commit into
Closed
[SPARK-52600][CONNECT] Move CompletionIterator to common/utils#51311huanliwang-db wants to merge 1 commit into
huanliwang-db wants to merge 1 commit into
Conversation
Contributor
Author
|
@cloud-fan can you please help review this change? |
HyukjinKwon
approved these changes
Jun 30, 2025
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move out util class CompletionIterator from
core/src/main/scala/org/apache/spark/util/CompletionIterator.scalatocommon/utils/src/main/scala/org/apache/spark/util/CompletionIterator.scalasuch that Spark Connect Scala client does not need to depend on Spark.Why are the changes needed?
When completionIterator is used in spark connect client, we don't need to depend on spark
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing test, clean refactor
Was this patch authored or co-authored using generative AI tooling?
no