[SPARK-52626][SQL] Allow grouping by the time type#51325
Closed
bersprockets wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-52626][SQL] Allow grouping by the time type#51325bersprockets wants to merge 2 commits intoapache:masterfrom
bersprockets wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @MaxGekk |
dongjoon-hyun
approved these changes
Jul 1, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @bersprockets .
HyukjinKwon
approved these changes
Jul 1, 2025
MaxGekk
approved these changes
Jul 1, 2025
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support the time type in
HashMapGenerator#genComputeHash.Why are the changes needed?
Allow grouping by the time type when wholestage codegen is on (it already works when wholestage codegen is off).
Does this PR introduce any user-facing change?
No. The time type is not released yet.
How was this patch tested?
New test.
Was this patch authored or co-authored using generative AI tooling?
No.