[SPARK-52808][CORE] spark.history.retainedApplications should be positive
#51504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @peter-toth |
peter-toth
approved these changes
Jul 15, 2025
Member
Author
|
Thank you, @peter-toth ! |
Member
Author
|
Since this is a simple config value check, I'll merge this for Apache Spark 4.1.0-preview2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add a config value validation for
spark.history.retainedApplicationsWhy are the changes needed?
To prevent a misleading situation from the beginning.
For example, in case of
spark.history.retainedApplications=0, Apache Spark shows a job list, but unable to show a job withToo many redirects...messages. Although this is not a Spark job, a user may be confused that this is a Spark bug.Does this PR introduce any user-facing change?
No. Previously, SHS didn't work correctly already.
How was this patch tested?
Pass the CIs.
Since this is a check at SparkConf level, the failure happens before SparkHistory server is created. So, we cannot add a test case for this one to HistoryServerSuite.
We can test it manually like the following.
SparkHistoryServerstops at the beginning.Was this patch authored or co-authored using generative AI tooling?
No.