[SPARK-6054][SQL] Fix transformations of TreeNodes that hold StructTypes#5157
Closed
marmbrus wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-6054][SQL] Fix transformations of TreeNodes that hold StructTypes#5157marmbrus wants to merge 1 commit intoapache:masterfrom
marmbrus wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #29060 has finished for PR 5157 at commit
|
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Mar 24, 2015
Due to a recent change that made `StructType` a `Seq` we started inadvertently turning `StructType`s into generic `Traversable` when attempting nested tree transformations. In this PR we explicitly avoid descending into `DataType`s to avoid this bug. Author: Michael Armbrust <michael@databricks.com> Closes #5157 from marmbrus/udfFix and squashes the following commits: 26f7087 [Michael Armbrust] Fix transformations of TreeNodes that hold StructTypes (cherry picked from commit 3fa3d12) Signed-off-by: Michael Armbrust <michael@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a recent change that made
StructTypeaSeqwe started inadvertently turningStructTypes into genericTraversablewhen attempting nested tree transformations. In this PR we explicitly avoid descending intoDataTypes to avoid this bug.