[SPARK-52929][SQL] Support MySQL and SQLServer connector for DSv2 Join pushdown#51637
Closed
PetarVasiljevic-DB wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-52929][SQL] Support MySQL and SQLServer connector for DSv2 Join pushdown#51637PetarVasiljevic-DB wants to merge 1 commit intoapache:masterfrom
PetarVasiljevic-DB wants to merge 1 commit intoapache:masterfrom
Conversation
a198c44 to
490d1d7
Compare
cloud-fan
approved these changes
Jul 24, 2025
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to #51594, I am enabling the join pushdown for MySQL and SQLServer connectors.
Additionally, I am moving
JoinPushdownAliasGeneratortoJdbcSQLQueryBuilderand using it there as well to generate new subquery alias used for full join subquery (previously, subqueries were generated only for left and right side, but now the whole thing needs to be subqueried). This is needed for these 2 dialects. H2, Oracle and Postgres didn't hit this issue, but they also still work with this, so there is no need for specialization.Why are the changes needed?
MySQL and SQLServer connectors don't support join pushdown.
Does this PR introduce any user-facing change?
No, since the flag
spark.sql.optimizer.datasourceV2JoinPushdownis disabled. If enabled, it will be attempted to push down to join directly to the scan node.How was this patch tested?
New tests.
Was this patch authored or co-authored using generative AI tooling?