[SPARK-53205][CORE][SQL] Support createParentDirs in SparkFileUtils#51932
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-53205][CORE][SQL] Support createParentDirs in SparkFileUtils#51932dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
createParentDirs in SparkFileUtils#51932dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Member
Author
|
Could you review this PR when you have some time, @viirya ? All Scala/Java tests passed. |
viirya
reviewed
Aug 8, 2025
| } | ||
| val parent = file.getParentFile() | ||
| if (parent != null) { | ||
| Files.createDirectories(parent.toPath()) |
Member
There was a problem hiding this comment.
What's the difference between this and parent.mkdirs()?
Btw, should we handle the following like com.google.common.io.Files?
if (!parent.isDirectory()) {
throw new IOException("Unable to create parent directories of " + file);
}
Member
Author
There was a problem hiding this comment.
Files.createDirectories is a newer API than File.mkdirs. In our case, we just want to make it sure that the directory exists. Since Files.createDirectories doesn't complain on the existing directory. That works for our use case.
viirya
approved these changes
Aug 8, 2025
Member
Author
|
Thank you, @viirya . All tests passed. |
Member
Author
|
Let me merge this. If we need a use case to fail at the existing directory, we can revise the method later~ Merged to master for Apache Spark 4.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
createParentDirsinSparkFileUtils.Why are the changes needed?
To improve Spark's file utility functions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.