[SPARK-53303][SS][CONNECT] Use the empty state encoder when the initial state is not provided in TWS #52056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val initialStateEncoder = if (initialState.isDefined) { | ||
| agnosticEncoderFor[S] | ||
| } else { | ||
| // Can not use `agnosticEncoderFor[S]` here because it points to incorrect encoder |
Contributor
|
@huanliwang-db - linter failure seems relevant ? |
anishshri-db
approved these changes
Aug 18, 2025
Contributor
anishshri-db
left a comment
anishshri-db
left a comment
There was a problem hiding this comment.
+1 - pending comments and green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
agnosticEncoderFor[S]returns the wrong encoder when no initial state is provided in TWS. We should create an empty state encoder and use that instead.Why are the changes needed?
Fix the incorrect behavior for TWS without initial state in spark connect
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A: unfortunately, this field is not used so far and it's not easy to provide the test coverage for this
Was this patch authored or co-authored using generative AI tooling?
No