[SPARK-6556][Core] Fix wrong parsing logic of executorTimeoutMs and checkTimeoutIntervalMs in HeartbeatReceiver

[zsxwing]

The current reading logic of executorTimeoutMs is:

private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout", 
    sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) * 1000

So if spark.storage.blockManagerSlaveTimeoutMs is 10000 and spark.network.timeout is not set, executorTimeoutMs will be 10000 * 1000. But the correct value should have been 10000.

checkTimeoutIntervalMs has the same issue.

This PR fixes them.

[SparkQA]

Test build #29226 has started for PR 5209 at commit ccd5147.

• This patch merges cleanly.

[srowen]

You might comment that timeout is in seconds and (obviously) blockManagerSlaveTimeoutMs is milliseconds. I agree with the change though. These properties you're fixing aren't documented right? the only ref I saw on the mailing list clearly directed people to set values like "60000", which is correctly in ms.

[zsxwing]

I have not seen them in any docs. However, from the current codes here, I think it's trying to maintain the compatibility.

[SparkQA]

Test build #29227 has started for PR 5209 at commit c7d5422.

• This patch merges cleanly.

[lianhuiwang]

LGTM

[SparkQA]

Test build #29226 has finished for PR 5209 at commit ccd5147.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29226/
Test PASSed.

[SparkQA]

Test build #29227 has finished for PR 5209 at commit c7d5422.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29227/
Test PASSed.

[sryza]

Minor nits on the comments:

• I wouldn't use backticks here because it's not md-formatted.
• "use" -> "uses"
• "while" should be on line above

[sryza]

Had some nits on the comments. Otherwise this LGTM.

[zsxwing]

Fixed the docs

[SparkQA]

Test build #29288 has started for PR 5209 at commit 6a0a411.

• This patch merges cleanly.

[SparkQA]

Test build #29288 has finished for PR 5209 at commit 6a0a411.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29288/
Test PASSed.