[SPARK-53916][PYTHON] Deduplicate the variables in PythonArrowInput #52621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarutak
approved these changes
Oct 15, 2025
Member
sarutak
left a comment
sarutak
left a comment
There was a problem hiding this comment.
LGTM except for one minor comment.
| if (v > 0) v else Int.MaxValue | ||
| } | ||
|
|
||
| protected val maxBytesPerBatch = SQLConf.get.arrowMaxBytesPerBatch |
Member
There was a problem hiding this comment.
Is it better to declare type explicitly?
HyukjinKwon
approved these changes
Oct 15, 2025
Contributor
Author
|
merged to master |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Deduplicate the variables in PythonArrowInput ### Why are the changes needed? code clean up ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#52621 from zhengruifeng/unify_var_name. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Deduplicate the variables in PythonArrowInput
Why are the changes needed?
code clean up
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no