[SPARK-54075] [SQL] Make ResolvedCollation evaluable
#52779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Oct 29, 2025
dongjoon-hyun
approved these changes
Oct 29, 2025
Member
|
Merged to master. Thank you, @mihailoale-db and @cloud-fan . |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? In this PR I propose to make `ResolvedCollation` evaluable. By making `ResolvedCollation` evaluable, it can now pass the `canEvaluateWithinJoin` check, allowing the optimizer to use efficient hash joins for queries with inline COLLATE in join conditions (before this change we would fallback to `BroadcastNestedLoopJoin`). ### Why are the changes needed? To improve performance of specific queries (see added tests). ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52779 from mihailoale-db/makecollationresolvable. Authored-by: mihailoale-db <mihailo.aleksic@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose to make
ResolvedCollationevaluable. By makingResolvedCollationevaluable, it can now pass thecanEvaluateWithinJoincheck, allowing the optimizer to use efficient hash joins for queries with inline COLLATE in join conditions (before this change we would fallback toBroadcastNestedLoopJoin).Why are the changes needed?
To improve performance of specific queries (see added tests).
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No.