[SPARK-54184][K8S] Support spark.kubernetes.executor.deletedExecutorsCacheTimeout
#52884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sCacheTTLSeconds`
pan3793
reviewed
Nov 5, 2025
| .createWithDefault(true) | ||
|
|
||
| val KUBERNETES_DELETED_EXECUTORS_CACHE_TTL_SECONDS = | ||
| ConfigBuilder("spark.kubernetes.executor.deletedExecutorsCacheTTLSeconds") |
Member
There was a problem hiding this comment.
it also accepts human-readable strings, like 10s, 3min, can we eliminate Seconds in the config name then?
Member
Author
There was a problem hiding this comment.
My bad. You're right. I blindly searched TTL keyword and followed a bad practice. Let me revise this.
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
Member
Author
|
Thank you, @pan3793 . Also, cc @peter-toth . |
dongjoon-hyun
changed the title
spark.kubernetes.executor.deletedExecutorsCacheTTLSecondsspark.kubernetes.executor.deletedExecutorsCacheTimeout
pan3793
approved these changes
Nov 5, 2025
yaooqinn
approved these changes
Nov 5, 2025
Member
Author
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 5, 2025
…sCacheTimeout` ### What changes were proposed in this pull request? This PR aims to support `spark.kubernetes.executor.deletedExecutorsCacheTimeout`. ### Why are the changes needed? To allow users to control the TTL for the deleted executors cache. Previously, it has a hard-coded value. In some very slow clusters, we need to remember longer than 3 minutes. https://github.com/apache/spark/blob/a8e35c407bc5340f83b35e5a2f0b0767c6baadb0/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala#L54-L57 ### Does this PR introduce _any_ user-facing change? No behavior change because the default value is the same. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52884 from dongjoon-hyun/SPARK-54184. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit ada1908) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Thank you, @peter-toth . |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…sCacheTimeout` ### What changes were proposed in this pull request? This PR aims to support `spark.kubernetes.executor.deletedExecutorsCacheTimeout`. ### Why are the changes needed? To allow users to control the TTL for the deleted executors cache. Previously, it has a hard-coded value. In some very slow clusters, we need to remember longer than 3 minutes. https://github.com/apache/spark/blob/a8e35c407bc5340f83b35e5a2f0b0767c6baadb0/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala#L54-L57 ### Does this PR introduce _any_ user-facing change? No behavior change because the default value is the same. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52884 from dongjoon-hyun/SPARK-54184. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
spark.kubernetes.executor.deletedExecutorsCacheTimeout.Why are the changes needed?
To allow users to control the TTL for the deleted executors cache.
Previously, it has a hard-coded value. In some very slow clusters, we need to remember longer than 3 minutes.
spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
Lines 54 to 57 in a8e35c4
Does this PR introduce any user-facing change?
No behavior change because the default value is the same.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.