[MINOR][TESTS][DOCS] Make bfill/backfill tests not dependent on natural order #52924
+37
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Nov 6, 2025
zhengruifeng
approved these changes
Nov 7, 2025
Contributor
|
merged to master |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
…al order ### What changes were proposed in this pull request? This PR adds explicit `.sort_index()` calls to pandas API tests for `bfill()` and `backfill()` operations to ensure deterministic test results. ### Why are the changes needed? The `bfill()` (backward fill) and `backfill()` operations in PySpark pandas API don't guarantee a specific output ordering. Tests that directly compared the results without sorting could fail intermittently due to differences in the natural ordering of results between pandas and PySpark implementations. By adding `.sort_index()` to both sides of the test assertions, we ensure tests are order-independent and deterministic. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52924 from Yicong-Huang/no-ticket/test/no-dependent-on-natural-order. Authored-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…al order ### What changes were proposed in this pull request? This PR adds explicit `.sort_index()` calls to pandas API tests for `bfill()` and `backfill()` operations to ensure deterministic test results. ### Why are the changes needed? The `bfill()` (backward fill) and `backfill()` operations in PySpark pandas API don't guarantee a specific output ordering. Tests that directly compared the results without sorting could fail intermittently due to differences in the natural ordering of results between pandas and PySpark implementations. By adding `.sort_index()` to both sides of the test assertions, we ensure tests are order-independent and deterministic. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52924 from Yicong-Huang/no-ticket/test/no-dependent-on-natural-order. Authored-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds explicit
.sort_index()calls to pandas API tests forbfill()andbackfill()operations to ensure deterministic test results.Why are the changes needed?
The
bfill()(backward fill) andbackfill()operations in PySpark pandas API don't guarantee a specific output ordering. Tests that directly compared the results without sorting could fail intermittently due to differences in the natural ordering of results between pandas and PySpark implementations.By adding
.sort_index()to both sides of the test assertions, we ensure tests are order-independent and deterministic.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.