Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Nov 10, 2025

What changes were proposed in this pull request?

This PR aims to recover CI by removing import sys from test_python_datasource.py
After #52967, CI consistently fails because sys is no longer used.

Why are the changes needed?

To recover CI.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@sarutak sarutak changed the title [SPARK-54065][FOLLOWUP] [SPARK-54065][FOLLOWUP] Remove unused import module from test_python_datasource.py Nov 10, 2025
@sarutak sarutak marked this pull request as ready for review November 10, 2025 08:49
@sarutak sarutak changed the title [SPARK-54065][FOLLOWUP] Remove unused import module from test_python_datasource.py [SPARK-54065][PYTHON][TESTS][FOLLOWUP] Remove unused import module from test_python_datasource.py Nov 10, 2025
@sarutak
Copy link
Member Author

sarutak commented Nov 10, 2025

cc: @dongjoon-hyun @LuciferYang

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

zhengruifeng pushed a commit that referenced this pull request Nov 10, 2025
…om `test_python_datasource.py`

### What changes were proposed in this pull request?
This PR aims to recover CI by removing `import sys` from `test_python_datasource.py`
After #52967, CI consistently fails because `sys` is no longer used.

### Why are the changes needed?
To recover CI.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #52970 from sarutak/followup-SPARK-54065.

Authored-by: Kousuke Saruta <sarutak@amazon.co.jp>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 8cc76fe)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
@zhengruifeng
Copy link
Contributor

thanks for the quick fix.
merged to master/4.1

@dongjoon-hyun
Copy link
Member

Oh. Thank you so much for the quick follow-up fix and merging, @sarutak and @zhengruifeng .

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
…om `test_python_datasource.py`

### What changes were proposed in this pull request?
This PR aims to recover CI by removing `import sys` from `test_python_datasource.py`
After apache#52967, CI consistently fails because `sys` is no longer used.

### Why are the changes needed?
To recover CI.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#52970 from sarutak/followup-SPARK-54065.

Authored-by: Kousuke Saruta <sarutak@amazon.co.jp>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
huangxiaopingRD pushed a commit to huangxiaopingRD/spark that referenced this pull request Nov 25, 2025
…om `test_python_datasource.py`

### What changes were proposed in this pull request?
This PR aims to recover CI by removing `import sys` from `test_python_datasource.py`
After apache#52967, CI consistently fails because `sys` is no longer used.

### Why are the changes needed?
To recover CI.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#52970 from sarutak/followup-SPARK-54065.

Authored-by: Kousuke Saruta <sarutak@amazon.co.jp>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants