Skip to content

Conversation

@Lewuathe
Copy link
Contributor

@Lewuathe Lewuathe commented Apr 1, 2015

This is the sub-task of SPARK-6254.
Wrap missing method for StandardScalerModel.

@Lewuathe Lewuathe changed the title [SPARK-6643] Implement StandardScalerModel missing methods [SPARK-6643][MLLIB] Implement StandardScalerModel missing methods Apr 1, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses mean or not -> uses std or not?

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29545 has finished for PR 5310 at commit 82683a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Apr 3, 2015

@viirya Thank you for comment. I updated.

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29672 has finished for PR 5310 at commit a38f155.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lewuathe The wrapper doesn't do anything different that StandardScalerModel. Do we really need it?

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Apr 4, 2015

@mengxr Yes. If I think again, it is unnecessary. Thank you for pointing out. I updated.

@mengxr
Copy link
Contributor

mengxr commented Apr 7, 2015

LGTM. Let's retry Jenkins.

test this please

@mengxr
Copy link
Contributor

mengxr commented Apr 7, 2015

test this please

@SparkQA
Copy link

SparkQA commented Apr 7, 2015

Test build #29817 has finished for PR 5310 at commit bd31a64.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@mengxr
Copy link
Contributor

mengxr commented Apr 9, 2015

@Lewuathe You need an extra empty line to pass python style checker. Try dev/lint-python on your local and see the error message.

@Lewuathe
Copy link
Contributor Author

@mengxr I updated. Thank you!

@SparkQA
Copy link

SparkQA commented Apr 11, 2015

Test build #30073 has finished for PR 5310 at commit fafd690.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@mengxr
Copy link
Contributor

mengxr commented Apr 13, 2015

Merged into master. Thanks!

@asfgit asfgit closed this in fc17661 Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants