-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-6643][MLLIB] Implement StandardScalerModel missing methods #5310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses mean or not -> uses std or not?
|
Test build #29545 has finished for PR 5310 at commit
|
|
@viirya Thank you for comment. I updated. |
|
Test build #29672 has finished for PR 5310 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lewuathe The wrapper doesn't do anything different that StandardScalerModel. Do we really need it?
|
@mengxr Yes. If I think again, it is unnecessary. Thank you for pointing out. I updated. |
|
LGTM. Let's retry Jenkins. test this please |
|
test this please |
|
Test build #29817 has finished for PR 5310 at commit
|
|
@Lewuathe You need an extra empty line to pass python style checker. Try |
|
@mengxr I updated. Thank you! |
|
Test build #30073 has finished for PR 5310 at commit
|
|
Merged into master. Thanks! |
This is the sub-task of SPARK-6254.
Wrap missing method for
StandardScalerModel.