Skip to content

Conversation

@aokolnychyi
Copy link
Contributor

What changes were proposed in this pull request?

This PR fixes error formatting for recently added incompatible table metadata checks.

Why are the changes needed?

These changes are needed to avoid unnecessary empty lines.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Nov 18, 2025
@aokolnychyi
Copy link
Contributor Author

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, please use a different JIRA ID when ASF Infra is back, @aokolnychyi .

[SPARK-53924][SPARK-54157][SQL][FOLLOWUP] Fix error formatting for incompatible table metadata checks

@aokolnychyi
Copy link
Contributor Author

Sounds good, @dongjoon-hyun. When do you recommend using FOLLOWUP tags?

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting fix looks good.

@dongjoon-hyun
Copy link
Member

Sounds good, @dongjoon-hyun. When do you recommend using FOLLOWUP tags?

Specifically, I don't recommend to use [FOLLOWUP] for multiple JIRA IDs, @aokolnychyi , because initially two original JIRA issues have independent theme already. When you aims to do a cross-theme style fix like this, it should be an independent JIRA issue.

@aokolnychyi
Copy link
Contributor Author

Makes sense. Thanks for explaining, @dongjoon-hyun!

@aokolnychyi aokolnychyi changed the title [SPARK-53924][SPARK-54157][SQL][FOLLOWUP] Fix error formatting for incompatible table metadata checks [SPARK-54436][SQL] Fix error formatting for incompatible table metadata checks Nov 20, 2025
@aokolnychyi
Copy link
Contributor Author

@dongjoon-hyun, created a new JIRA issue and updated the title. Let me know if anything else is needed.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @aokolnychyi and all

dongjoon-hyun pushed a commit that referenced this pull request Nov 20, 2025
…ta checks

### What changes were proposed in this pull request?

This PR fixes error formatting for recently added incompatible table metadata checks.

### Why are the changes needed?

These changes are needed to avoid unnecessary empty lines.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #53115 from aokolnychyi/spark-53924-54157-followup.

Authored-by: Anton Okolnychyi <aokolnychyi@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 8cab074)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

Merged to master/4.1 for Apache Spark 4.1.0.

@aokolnychyi
Copy link
Contributor Author

huangxiaopingRD pushed a commit to huangxiaopingRD/spark that referenced this pull request Nov 25, 2025
…ta checks

### What changes were proposed in this pull request?

This PR fixes error formatting for recently added incompatible table metadata checks.

### Why are the changes needed?

These changes are needed to avoid unnecessary empty lines.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#53115 from aokolnychyi/spark-53924-54157-followup.

Authored-by: Anton Okolnychyi <aokolnychyi@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants