-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-54436][SQL] Fix error formatting for incompatible table metadata checks #53115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…compatible table metadata checks
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind, please use a different JIRA ID when ASF Infra is back, @aokolnychyi .
[SPARK-53924][SPARK-54157][SQL][FOLLOWUP] Fix error formatting for incompatible table metadata checks
|
Sounds good, @dongjoon-hyun. When do you recommend using FOLLOWUP tags? |
viirya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting fix looks good.
Specifically, I don't recommend to use |
|
Makes sense. Thanks for explaining, @dongjoon-hyun! |
|
@dongjoon-hyun, created a new JIRA issue and updated the title. Let me know if anything else is needed. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @aokolnychyi and all
…ta checks ### What changes were proposed in this pull request? This PR fixes error formatting for recently added incompatible table metadata checks. ### Why are the changes needed? These changes are needed to avoid unnecessary empty lines. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53115 from aokolnychyi/spark-53924-54157-followup. Authored-by: Anton Okolnychyi <aokolnychyi@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 8cab074) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/4.1 for Apache Spark 4.1.0. |
…ta checks ### What changes were proposed in this pull request? This PR fixes error formatting for recently added incompatible table metadata checks. ### Why are the changes needed? These changes are needed to avoid unnecessary empty lines. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53115 from aokolnychyi/spark-53924-54157-followup. Authored-by: Anton Okolnychyi <aokolnychyi@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR fixes error formatting for recently added incompatible table metadata checks.
Why are the changes needed?
These changes are needed to avoid unnecessary empty lines.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.