Skip to content

[SPARK-6651][MLLIB] delegate dense vector arithmetics to the underlying numpy array #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mengxr wants to merge 2 commits into from
Closed

[SPARK-6651][MLLIB] delegate dense vector arithmetics to the underlying numpy array #5312

mengxr wants to merge 2 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Apr 1, 2015

Users should be able to use numpy operators directly on dense vectors. @davies @atalwalkar

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29549 has started for PR 5312 at commit 98534af.

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29550 has started for PR 5312 at commit 23dfca3.

davies
davies reviewed Apr 1, 2015
View reviewed changes
python/pyspark/mllib/linalg.py Outdated
Copy link
Contributor

@davies davies Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return an DenseVector?

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29553 has started for PR 5312 at commit e665c5c.

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29549 has finished for PR 5312 at commit 98534af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 1, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29549/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29550 has finished for PR 5312 at commit 23dfca3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 1, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29550/
Test PASSed.

@davies
Copy link
Contributor

davies commented Apr 1, 2015

LGTM, thanks!

@mengxr
Copy link
Contributor Author

mengxr commented Apr 1, 2015

Merged into master and branch-1.3.

asfgit pushed a commit that referenced this pull request Apr 1, 2015
@mengxr
[SPARK-6651][MLLIB] delegate dense vector arithmetics to the underlyi…
f50d95a 
…ng numpy array

Users should be able to use numpy operators directly on dense vectors. davies atalwalkar

Author: Xiangrui Meng <meng@databricks.com>

Closes #5312 from mengxr/SPARK-6651 and squashes the following commits:

e665c5c [Xiangrui Meng] wrap the result in a dense vector
23dfca3 [Xiangrui Meng] delegate dense vector arithmetics to the underlying numpy array

(cherry picked from commit 2275acc)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 2275acc Apr 1, 2015
@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29553 has finished for PR 5312 at commit e665c5c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 1, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29553/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @SparkQA @AmplabJenkins @davies