[SPARK-54435][SDP] spark-pipelines init should avoid overwriting existing directory #53140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Nov 20, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM for this init fix. Thank you, @sryza .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 20, 2025
…ting directory ### What changes were proposed in this pull request? If the name provided to `spark-pipelines init` matches an existing directory, raises an error instead of overwriting the existing directory's contents. ### Why are the changes needed? Help users avoid accidentally overwriting their code. ### Does this PR introduce _any_ user-facing change? Yes, to an unreleased version. ### How was this patch tested? Added unit test for the cases where init is invoked with an existing directory. ### Was this patch authored or co-authored using generative AI tooling? Closes #53140 from sryza/initoverwrite. Authored-by: Sandy Ryza <sandy.ryza@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6811eab) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/4.1. |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ting directory ### What changes were proposed in this pull request? If the name provided to `spark-pipelines init` matches an existing directory, raises an error instead of overwriting the existing directory's contents. ### Why are the changes needed? Help users avoid accidentally overwriting their code. ### Does this PR introduce _any_ user-facing change? Yes, to an unreleased version. ### How was this patch tested? Added unit test for the cases where init is invoked with an existing directory. ### Was this patch authored or co-authored using generative AI tooling? Closes apache#53140 from sryza/initoverwrite. Authored-by: Sandy Ryza <sandy.ryza@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the name provided to
spark-pipelines initmatches an existing directory, raises an error instead of overwriting the existing directory's contents.Why are the changes needed?
Help users avoid accidentally overwriting their code.
Does this PR introduce any user-facing change?
Yes, to an unreleased version.
How was this patch tested?
Added unit test for the cases where init is invoked with an existing directory.
Was this patch authored or co-authored using generative AI tooling?