Skip to content

[SPARK-54454][SQL] Enable variant shredding and variant logical type annotation configs by default #53164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+4 −4
Open

[SPARK-54454][SQL] Enable variant shredding and variant logical type annotation configs by default #53164

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b07a84
enable variant shredding configs by default
harshmotw-db Nov 21, 2025
3a601f8
resolve unit test failures
harshmotw-db Nov 25, 2025
02ab583
fix default resolution for push_variant_into_scan
harshmotw-db Nov 25, 2025
b65b85d
fix
harshmotw-db Nov 25, 2025
29a87b4
fix
harshmotw-db Nov 25, 2025
b4332b7
fix
harshmotw-db Nov 25, 2025
23e6a1d
address comments
harshmotw-db Nov 26, 2025
34dfe8e
fix
harshmotw-db Nov 26, 2025
0e12ecd
Apply suggestions from code review
cloud-fan Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,7 +1598,7 @@ object SQLConf {
"variant logical type.")
.version("4.1.0")
.booleanConf
.createWithDefault(false)
.createWithDefault(true)
Copy link
Contributor

@cloud-fan cloud-fan Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least enable this config in 4.1, to conform to the Parquet spec. If many people start to use variant type with Spark 4.1, then the entire ecosystem may be forced to support the Spark-specific variant type in Parquet.

@harshmotw-db can we open a separate PR for this config? And also cc @dongjoon-hyun


val PARQUET_IGNORE_VARIANT_ANNOTATION =
buildConf("spark.sql.parquet.ignoreVariantAnnotation")
Expand Down Expand Up @@ -5610,15 +5610,15 @@ object SQLConf {
"requested fields.")
.version("4.0.0")
.booleanConf
.createWithDefault(false)
.createWithDefault(true)

val VARIANT_WRITE_SHREDDING_ENABLED =
buildConf("spark.sql.variant.writeShredding.enabled")
.internal()
.doc("When true, the Parquet writer is allowed to write shredded variant. ")
.version("4.0.0")
.booleanConf
.createWithDefault(false)
.createWithDefault(true)

val VARIANT_FORCE_SHREDDING_SCHEMA_FOR_TEST =
buildConf("spark.sql.variant.forceShreddingSchemaForTest")
Expand Down Expand Up @@ -5651,7 +5651,7 @@ object SQLConf {
.doc("Infer shredding schema when writing Variant columns in Parquet tables.")
.version("4.1.0")
.booleanConf
.createWithDefault(false)
.createWithDefault(true)

val LEGACY_CSV_ENABLE_DATE_TIME_PARSING_FALLBACK =
buildConf("spark.sql.legacy.csv.enableDateTimeParsingFallback")
Expand Down