[SPARK-54508][PYTHON] Fix spark-pipelines to resolve spec file path more robustly
#53219
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
spark-pipelines fails when spec file is in different directory
dongjoon-hyun
changed the title
spark-pipelines fails when spec file is in different directoryspark-pipelines to resolve spec file path more robustly
dongjoon-hyun
approved these changes
Nov 25, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @sryza .
Merged to master/4.1 for Apache Spark 4.1.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 25, 2025
…th more robustly ### What changes were proposed in this pull request? Fixes a bug that causes executing `spark-pipelines` with a spec file in a subdirectory to fail: ``` spark-pipelines run --spec subdir/spark-pipelines.yml ``` results in ``` pyspark.errors.exceptions.connect.AnalysisException: [RUN_EMPTY_PIPELINE] Pipelines are expected to have at least one non-temporary dataset defined (tables, persisted views) but no non-temporary datasets were found in your pipeline. ``` ### Why are the changes needed? Fix a bug. ### Does this PR introduce _any_ user-facing change? Fixes a user-facing bug ### How was this patch tested? Ran ``` spark-pipelines run --spec subdir/spark-pipelines.yml ``` Observed it fail before the change and succeed after. With our current Pipelines CLI unit testing setup, there isn't a straightforward way to write a test for this, but I'm investigating whether we can augment it. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53219 from sryza/cli-relative-path. Authored-by: Sandy Ryza <sandy.ryza@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit c61d40c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes a bug that causes executing
spark-pipelineswith a spec file in a subdirectory to fail:results in
Why are the changes needed?
Fix a bug.
Does this PR introduce any user-facing change?
Fixes a user-facing bug
How was this patch tested?
Ran
Observed it fail before the change and succeed after.
With our current Pipelines CLI unit testing setup, there isn't a straightforward way to write a test for this, but I'm investigating whether we can augment it.
Was this patch authored or co-authored using generative AI tooling?
No.