Skip to content

[SPARK-54508][PYTHON] Fix spark-pipelines to resolve spec file path more robustly #53219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+3 −2
Closed

[SPARK-54508][PYTHON] Fix spark-pipelines to resolve spec file path more robustly #53219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/pyspark/pipelines/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ def register_definitions(
- Import Python files matching the glob patterns in the spec.
- Register SQL files matching the glob patterns in the spec.
"""
path = spec_path.parent
path = spec_path.parent.resolve()

with change_dir(path):
with graph_element_registration_context(registry):
log_with_curr_timestamp(f"Loading definitions. Root directory: '{path}'.")
Expand Down Expand Up @@ -260,7 +261,7 @@ def register_definitions(
log_with_curr_timestamp(f"Registering SQL file {file}...")
with file.open("r") as f:
sql = f.read()
file_path_relative_to_spec = file.relative_to(spec_path.parent)
file_path_relative_to_spec = file.relative_to(path)
registry.register_sql(sql, file_path_relative_to_spec)
else:
raise PySparkException(
Expand Down