[SPARK-54485][SPARK-54494][PYTHON][TESTS][4.0] Re-enable tests in test_parity_udf_profiler and test_parity_memory_profiler #53222
+51
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
changed the title
| return contextlib.nullcontext() | ||
|
|
||
|
|
||
| def skip_if_server_version_is( |
Contributor
There was a problem hiding this comment.
this seems to be a helper decorator. should we make it a private one?
Member
Author
There was a problem hiding this comment.
What do you mean by "make it a private one"?
I don't intend it to be a private as it's complete usable, but I'm ok to make it a private. WDYT? @HyukjinKwon
Member
There was a problem hiding this comment.
It's fine. let's just leave it
Member
Author
|
If the decorators look good, I'll submit a PR against master to forward-port them. |
HyukjinKwon
approved these changes
Nov 25, 2025
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Oh, I like this. We should put the util in master too
ueshin
changed the title
Member
Author
|
#53223 for forward-port. |
allisonwang-db
approved these changes
Nov 26, 2025
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 26, 2025
…ct parity tests ### What changes were proposed in this pull request? This PR aims to add utility decorators in Spark Connect cross version tests. - `skip_if_server_version_is` - `skip_if_server_version_is_greater_than_or_equal_to` ### Why are the changes needed? This is a forward-port from #53222. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53223 from ueshin/issues/SPARK-54517/decorators. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 26, 2025
…ct parity tests ### What changes were proposed in this pull request? This PR aims to add utility decorators in Spark Connect cross version tests. - `skip_if_server_version_is` - `skip_if_server_version_is_greater_than_or_equal_to` ### Why are the changes needed? This is a forward-port from #53222. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53223 from ueshin/issues/SPARK-54517/decorators. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d9dcb5c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
changed the title
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
I merged the utility function PRs to master/4.1.
…54485_54494/profiler_tests
Member
Author
|
The failed tests are Retrying just in case: |
Member
|
That's fine. Merged to branch-4.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Nov 26, 2025
…t_parity_udf_profiler and test_parity_memory_profiler ### What changes were proposed in this pull request? Re-enables tests in `test_parity_udf_profiler` and `test_parity_memory_profiler`. Added utility decorators for Spark Connect parity tests. - `skip_if_server_version_is` - `skip_if_server_version_is_greater_than_or_equal_to` ### Why are the changes needed? Some tests are disabled due to Spark Connect cross version tests. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Modified the related tests to use the utility. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53222 from ueshin/issues/SPARK-54485_54494/profiler_tests. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Re-enables tests in
test_parity_udf_profilerandtest_parity_memory_profiler.Added utility decorators for Spark Connect parity tests.
skip_if_server_version_isskip_if_server_version_is_greater_than_or_equal_toWhy are the changes needed?
Some tests are disabled due to Spark Connect cross version tests.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modified the related tests to use the utility.
Was this patch authored or co-authored using generative AI tooling?
No.