[SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests #53223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Nov 25, 2025
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Nov 26, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @ueshin and @HyukjinKwon .
Merged to master/4.1.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 26, 2025
…ct parity tests ### What changes were proposed in this pull request? This PR aims to add utility decorators in Spark Connect cross version tests. - `skip_if_server_version_is` - `skip_if_server_version_is_greater_than_or_equal_to` ### Why are the changes needed? This is a forward-port from #53222. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53223 from ueshin/issues/SPARK-54517/decorators. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d9dcb5c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Hi, @ueshin . It seems a little weird but this PR causes some CI failures. Could you take a look at that? https://github.com/apache/spark/actions/runs/19711591103/job/56473581543 (Python 3.10) |
Member
Author
|
@dongjoon-hyun oh, sure, let me check. |
Member
|
Thank you so much~ |
Member
Author
|
Submitted the follow-up: #53238 |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 26, 2025
### What changes were proposed in this pull request? This is a follow-up of #53223. Fixes a typehint using ellipsis that are not available as type arguments in Python 3.10. ### Why are the changes needed? #53223 caused a test failure in Python 3.10 tests: ``` File "/__w/spark/spark/python/pyspark/testing/connectutils.py", line 312, in <module> ) -> Callable[[...], ...]: ^^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 1206, in __getitem__ return self.__getitem_inner__(params) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 312, in inner return func(*args, **kwds) ^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 1212, in __getitem_inner__ result = _type_check(result, msg) ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 176, in _type_check raise TypeError(f"{msg} Got {arg!r:.100}.") TypeError: Callable[args, result]: result must be a type. Got Ellipsis. ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53238 from ueshin/issues/SPARK-54517/typehints. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 26, 2025
### What changes were proposed in this pull request? This is a follow-up of #53223. Fixes a typehint using ellipsis that are not available as type arguments in Python 3.10. ### Why are the changes needed? #53223 caused a test failure in Python 3.10 tests: ``` File "/__w/spark/spark/python/pyspark/testing/connectutils.py", line 312, in <module> ) -> Callable[[...], ...]: ^^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 1206, in __getitem__ return self.__getitem_inner__(params) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 312, in inner return func(*args, **kwds) ^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 1212, in __getitem_inner__ result = _type_check(result, msg) ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 176, in _type_check raise TypeError(f"{msg} Got {arg!r:.100}.") TypeError: Callable[args, result]: result must be a type. Got Ellipsis. ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53238 from ueshin/issues/SPARK-54517/typehints. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit c11edf9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add utility decorators in Spark Connect cross version tests.
skip_if_server_version_isskip_if_server_version_is_greater_than_or_equal_toWhy are the changes needed?
This is a forward-port from #53222.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No.