[SPARK-54552][CONNECT] Fix SparkConnectResultSet.getString to handle BINARY data type with UTF_8
#53262
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @pan3793 , @dongjoon-hyun |
dongjoon-hyun
changed the title
SparkConnectResultSet.getString to handle BINARY data type with UTF_8
dongjoon-hyun
approved these changes
Nov 29, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @vinodkc .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 29, 2025
…e BINARY data type with `UTF_8`
### What changes were proposed in this pull request?
Fixed `SparkConnectResultSet.getString()` to properly convert BINARY data to UTF-8 strings instead of returning byte array object references (e.g., "[B<hashcode>").
### Why are the changes needed?
The current implementation violates JDBC specification behavior. Users calling getString() on BINARY columns expect UTF-8 decoded strings, not Java object references.
Before
```
SELECT binary('xDeAdBeEf')
spark-sql: `\xDeAdBeEf`
beeline with STS: `\xDeAdBeEf`
beeline with Connect Server: `[B4d518c66`
```
After
```
SELECT binary('xDeAdBeEf')
spark-sql: `\xDeAdBeEf`
beeline with STS: `\xDeAdBeEf`
beeline with Connect Server: `\xDeAdBeEf`
```
### Does this PR introduce _any_ user-facing change?
Yes. getString() on BINARY columns now returns UTF-8 decoded strings instead of byte array references like "[B1a2b3c4d".
### How was this patch tested?
Added new test
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #53262 from vinodkc/br_fix_getString_BINARY.
Authored-by: vinodkc <vinod.kc.in@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit f5b9ea8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/4.1 for Apache Spark 4.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed
SparkConnectResultSet.getString()to properly convert BINARY data to UTF-8 strings instead of returning byte array object references (e.g., "[B@").Why are the changes needed?
The current implementation violates JDBC specification behavior. Users calling getString() on BINARY columns expect UTF-8 decoded strings, not Java object references.
Before
After
Does this PR introduce any user-facing change?
Yes. getString() on BINARY columns now returns UTF-8 decoded strings instead of byte array references like "[B@1a2b3c4d".
How was this patch tested?
Added new test
Was this patch authored or co-authored using generative AI tooling?
No