Revert "[SPARK-54423][SS] Introducing OffsetMap to enable Named Streaming Sources" #53329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ming Sources" This reverts commit 250ccca.
Contributor
Author
|
@anishshri-db @HeartSaVioR Can you PTAL |
Member
There was a problem hiding this comment.
To @ericm-db , don't we have a test case to find those regression yet?
This PR inadvertently introduced a format change in OffsetSeqMetadata.
Contributor
Author
|
@dongjoon-hyun Looking at the golden files, it seems that we do, but I think this addition would change what we persist to the offsets directory |
Contributor
Author
|
Ah, looking at how the json population works for missing fields, it seems that we would just use the default, so it is not catastrophic as I thought. |
Member
|
Thank you for sharing the analysis and closing this, @ericm-db . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 250ccca.
What changes were proposed in this pull request?
This PR inadvertently introduced a format change in OffsetSeqMetadata. Will re-introduce this change in a safer way.
Why are the changes needed?
We don't want to break any existing streaming queries, not sure if this change will but want to be on the safer side.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests will suffice.
Was this patch authored or co-authored using generative AI tooling?
No