[SPARK-46165][PS] Add support for pandas.DataFrame.all axis=1 #53507
+77
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
devin-petersohn
changed the title
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Contributor
Author
|
@HyukjinKwon This is ready for review. |
holdenk
reviewed
Jan 12, 2026
Comment on lines
+11153
to
+11154
| # pandas treats all NA values as True in `all()` | ||
| F.lit(True), |
Contributor
There was a problem hiding this comment.
Shouldn't this depend on skipNA's value? Although I see the test works without it so I'm probably missing soemthing.
Contributor
Author
There was a problem hiding this comment.
I thought so too, and my first commit had this but the tests kept failing. Turns out that in pandas docs it says that NA values are treated as True: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.all.html
HyukjinKwon
approved these changes
Jan 12, 2026
Contributor
|
Merged to master. Thanks @devin-petersohn for the PR! Thanks @HyukjinKwon @holdenk for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for
pandas.DataFrame.anyaxis=1Why are the changes needed?
To support a missing API parameter
Does this PR introduce any user-facing change?
Yes, new parameter for existing API
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No