[SPARK-54843][SQL] Try_to_number expression not working for empty string input #53609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankandic
changed the title
Contributor
Author
|
Please take a look when you get the chance @dtenedor @cloud-fan |
cloud-fan
approved these changes
Dec 26, 2025
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Dec 26, 2025
…ing input
### What changes were proposed in this pull request?
Catching the case in `ToNumberParser` when the input string only consists of whitespace, preventing a failure with an internal error later on when trying to create `BigDecimal`.
### Why are the changes needed?
Without this change passing an empty string (`select try_to_number('', '99')`) would fail with the following exception:
```
JVM stacktrace:
java.lang.NumberFormatException
at java.base/java.math.BigDecimal.(BigDecimal.java:692)
at java.base/java.math.BigDecimal.(BigDecimal.java:471)
at java.base/java.math.BigDecimal.(BigDecimal.java:900)
at org.apache.spark.sql.catalyst.util.ToNumberParser.parseResultToDecimalValue(ToNumberParser.scala:627)
at org.apache.spark.sql.catalyst.util.ToNumberParser.parse(ToNumberParser.scala:499)
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New unit tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #53609 from stefankandic/numFormatFix.
Authored-by: Stefan Kandic <stefan.kandic@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit df720c1)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Catching the case in
ToNumberParserwhen the input string only consists of whitespace, preventing a failure with an internal error later on when trying to createBigDecimal.Why are the changes needed?
Without this change passing an empty string (
select try_to_number('', '99')) would fail with the following exception:Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.