Skip to content

Conversation

@kopiczko
Copy link

@kopiczko kopiczko commented Apr 6, 2015

Hi,

I'd like to have that setting exposed to be able to set DynamoDB table (for KCL) in the same region as the Kinesis stream.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this changing the API?
I believe you should make a JIRA along with this PR. It's not trivial.
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

@cfregly
Copy link
Contributor

cfregly commented Apr 7, 2015

@srowen @kopiczko

This is part of a larger effort to overhaul Kinesis-based streaming slated for 1.4. Lots of API changes including region, AWS credentials, and application name - as well as upgrading both the AWS Java SDK and the KCL.

Here's the parent jira: https://issues.apache.org/jira/browse/SPARK-6599.

Here's the related jira that covers the region portion: https://issues.apache.org/jira/browse/SPARK-6514.

We should definitely try to be backward-compatible even though the API is Experimental.

@kopiczko
Copy link
Author

kopiczko commented Apr 7, 2015

Thanks guys for your response. @cfregly I've already answered your comment on Jira. I guess we should move our discussion there. I can improve this implementation to meet requirements in SPARK-6514 and rename PR according to guidelines in wiki.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to add a note similar to the KCL README.md when describing this param:

"The Amazon DynamoDB table and Amazon CloudWatch metrics associated with your application will also use this region setting."

@tdas
Copy link
Contributor

tdas commented May 5, 2015

Any updates on this patch? If you are not able to work on it, mind closing it?

@tdas
Copy link
Contributor

tdas commented Jun 19, 2015

This is not needed any more as Spark 1.4.0 has fixed this issue. Mind closing this PR?

@kopiczko
Copy link
Author

Sorry guys, I currently have no time to work on it. @tdas: Would you mind give a reference how this is solved?

@kopiczko kopiczko closed this Jun 20, 2015
@tdas
Copy link
Contributor

tdas commented Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants