-
Notifications
You must be signed in to change notification settings - Fork 29k
Expose regionName setting in Kinesis receiver configuration #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose regionName setting in Kinesis receiver configuration #5375
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this changing the API?
I believe you should make a JIRA along with this PR. It's not trivial.
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
|
This is part of a larger effort to overhaul Kinesis-based streaming slated for 1.4. Lots of API changes including region, AWS credentials, and application name - as well as upgrading both the AWS Java SDK and the KCL. Here's the parent jira: https://issues.apache.org/jira/browse/SPARK-6599. Here's the related jira that covers the region portion: https://issues.apache.org/jira/browse/SPARK-6514. We should definitely try to be backward-compatible even though the API is Experimental. |
|
Thanks guys for your response. @cfregly I've already answered your comment on Jira. I guess we should move our discussion there. I can improve this implementation to meet requirements in SPARK-6514 and rename PR according to guidelines in wiki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to add a note similar to the KCL README.md when describing this param:
"The Amazon DynamoDB table and Amazon CloudWatch metrics associated with your application will also use this region setting."
|
Any updates on this patch? If you are not able to work on it, mind closing it? |
|
This is not needed any more as Spark 1.4.0 has fixed this issue. Mind closing this PR? |
|
Sorry guys, I currently have no time to work on it. @tdas: Would you mind give a reference how this is solved? |
|
Sure, take a look at the new KinesisUtils API. |
Hi,
I'd like to have that setting exposed to be able to set DynamoDB table (for KCL) in the same region as the Kinesis stream.