-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-54944][PYTHON][TESTS] Add tests for pa.Array.to_pandas with default arguments #53763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JIRA Issue Information=== Sub-task SPARK-54944 === This comment was automatically generated by GitHub Actions |
|
I think for test only PRs we need to add [TESTS] in title |
| class PyArrowArrayToPandasTests(unittest.TestCase): | ||
| """Test pa.Array.to_pandas with default arguments.""" | ||
|
|
||
| def test_integer_types(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for to_pandas we have seen many OOM and SEGFAULT issues in PySpark, which underneath uses PyArrow's to_pandas. I hope we can cover more types especially for nested struct/list/json.
| # With nulls, integers convert to float64 by default (numpy doesn't have nullable int) | ||
| arr = pa.array([1, None, 3], type=pa.int64()) | ||
| series = arr.to_pandas() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about NaN?
7720374 to
6e42fe8
Compare
What changes were proposed in this pull request?
Add tests for pa.Array.to_pandas with default arguments
Why are the changes needed?
We want to monitor changes in PyArrow's behavior.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.5