[SPARK-55051][CORE] Byte string accepts KiB, MiB, GiB, TiB, PiB #53816
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Improvement SPARK-55051 === This comment was automatically generated by GitHub Actions |
Member
Author
peter-toth
approved these changes
Jan 16, 2026
LuciferYang
approved these changes
Jan 19, 2026
Contributor
|
Merged into master. Thanks @pan3793 and @peter-toth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enhances
JavaUtils.byteStringAsto support parsing the input string that has suffixesKi,KiB,Mi,MiB, and so on, which allows users to use, for example,2GiB, as the value of byte type configurations.Why are the changes needed?
Strictly speaking,
1KB = 1000Band1KiB = 1024B, while currently, Spark only accepts1Kor1KBand interprets it as1KiB.I'm not intending to "correct" it, but I think it should at least accept
1Kior1KiBas input, which usually gets complain by users who are familiar with K8s, as suffixMi,GiBare widely used in the K8s ecosystem.Does this PR introduce any user-facing change?
Yes, users are allowed to use
1Ki,2MiB, etc. as the value of byte type configurations.How was this patch tested?
UTs are added.
Was this patch authored or co-authored using generative AI tooling?
No.