[SPARK-55033][SQL][4.0] Fix stringArgs of DSv2 writing commands #53856
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Bug SPARK-55033 === This comment was automatically generated by GitHub Actions |
peter-toth
approved these changes
Jan 19, 2026
Replace `val stringArgs` with `def stringArgs` in v2 writing commands, because each call of the method `stringArgs` should return a brand-new `Iterator`, otherwise, subsequent consumers will get an empty result. Fix EXPLAIN / UI display. Yes, for example, without this fix, I found that some `AppendData` nodes in UI do not contain `Arguments: ...` where they should be, this patch makes them display correctly consistently. INSERT INTO an Iceberg table and check UI, before vs after. <img width="389" height="86" alt="image" src="https://github.com/user-attachments/assets/3bdb18e2-b605-497f-9431-ae416c340541" /> <img width="844" height="110" alt="image" src="https://github.com/user-attachments/assets/4ed3ea3f-4fcd-4b93-a1fd-2714c3fead12" /> No. Closes apache#53794 from pan3793/SPARK-55033. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Peter Toth <peter.toth@gmail.com>
pan3793
force-pushed
the
SPARK-55033-4.0
branch
from
c5306c8 to
c4da9bb
Compare
sarutak
approved these changes
Jan 19, 2026
sarutak
pushed a commit
that referenced
this pull request
Jan 19, 2026
Backport #53794 to branch-4.0 ### What changes were proposed in this pull request? Replace `val stringArgs` with `def stringArgs` in v2 writing commands, because each call of the method `stringArgs` should return a brand-new `Iterator`, otherwise, subsequent consumers will get an empty result. ### Why are the changes needed? Fix EXPLAIN / UI display. ### Does this PR introduce _any_ user-facing change? Yes, for example, without this fix, I found that some `AppendData` nodes in UI do not contain `Arguments: ...` where they should be, this patch makes them display correctly consistently. ### How was this patch tested? INSERT INTO an Iceberg table and check UI, before vs after. <img width="389" height="86" alt="image" src="https://github.com/user-attachments/assets/3bdb18e2-b605-497f-9431-ae416c340541" /> <img width="844" height="110" alt="image" src="https://github.com/user-attachments/assets/4ed3ea3f-4fcd-4b93-a1fd-2714c3fead12" /> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53856 from pan3793/SPARK-55033-4.0. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Kousuke Saruta <sarutak@apache.org>
Member
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #53794 to branch-4.0
What changes were proposed in this pull request?
Replace
val stringArgswithdef stringArgsin v2 writing commands, because each call of the methodstringArgsshould return a brand-newIterator, otherwise, subsequent consumers will get an empty result.Why are the changes needed?
Fix EXPLAIN / UI display.
Does this PR introduce any user-facing change?
Yes, for example, without this fix, I found that some
AppendDatanodes in UI do not containArguments: ...where they should be, this patch makes them display correctly consistently.How was this patch tested?
INSERT INTO an Iceberg table and check UI, before vs after.
Was this patch authored or co-authored using generative AI tooling?
No.