[SPARK-55093][CORE] Handle TaskRunner construction failures in launchTask #53865
+111
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2026 04:01
…on failure - Move createTaskRunner into try-catch block to handle construction failures - Add cleanup to remove TaskRunner from runningTasks if threadPool.execute throws - Prevent potential memory leak by cleaning up TaskRunner when threadPool.execute fails - Update test to use current TaskDescription API
- Use reflection to mock runningTasks.put to throw exception - Tests cleanup logic when TaskRunner is created but fails to be added to runningTasks - Verify exception is properly caught and reported to driver
JIRA Issue Information=== Bug SPARK-55093 === This comment was automatically generated by GitHub Actions |
Author
|
@cloud-fan @Ngone51 What do you think about this PR ? |
ChuckLin2025
changed the title
ChuckLin2025
changed the title
Ngone51
changed the title
cloud-fan
changed the title
…ng mocked Executor fields The test was failing because mocked Executor's val fields (runningTasks, threadPool, conf, env, killMarks) were not initialized when using mock[Executor](CALLS_REAL_METHODS). This caused NullPointerExceptions when the real launchTask method tried to access them. Solution: Use reflection to manually set these val fields on the mocked Executor object after creation, allowing the real launchTask method to execute properly and add tasks to the runningTasks map. Test now passes consistently in ~1.4 seconds.
Author
|
@Ngone51 Could you please take another look here ? I fix the test case "track allocated resources by taskId" in a new commit. The test case didn't mock the killMarks and ran into a null Exception. It passed before this PR because we didn't handle the exception and run the cleanup job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prevent potential memory leak by cleaning up TaskRunner when threadPool.execute fails
Why are the changes needed?
The createTaskRunner may throw an Exception.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added an unit test.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: claude-4.5