[SPARK-55185][SQL]. Fix for idempotency being broken, if InferFiltersFromConstraint rule is run as part of post optimization batch with fixed iterations #53968
+1,455
−1,383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…straint rule is run as part of post optimzation batch with fixed ietrations
JIRA Issue Information=== Bug SPARK-55185 === This comment was automatically generated by GitHub Actions |
…straint rule is run as part of post optimzation batch with fixed ietrations
ahshahid
changed the title
ahshahid
changed the title
Contributor
Author
|
The combined PR for SPARK-55185 and SPARK-55072 is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…straint rule is run as part of post optimization batch with fixed iterations
What changes were proposed in this pull request?
Running PropagateEmptyRelation rule after PruneFilters rule, as part of the rules
operatorOptimizationRuleSet, of the Optimizer class.
Why are the changes needed?
If InferFiltersFromConstraint rule is added to be run as part of the Batch "Operator Optimization after Inferring Filters", then the idempotency is not achieved in some cases.
The need for "InferFiltersFromConstraint" to be run as FixedPoint is needed for the following PR
#53838
Ideally behaviour of every rule should be such that removal or addition of a rule should not impact achievement of idempotency. So this is not an ideal fix, but since the constraints code especially when Union node is involved is , any ideal fix will be invasive, I believe this is a safe change.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added bug test
Was this patch authored or co-authored using generative AI tooling?
No