[SPARK-55226][PYTHON][PS] Recognize datetime and timedelta with units other than [ns] #53993
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Sub-task SPARK-55226 === This comment was automatically generated by GitHub Actions |
zhengruifeng
approved these changes
Jan 27, 2026
Contributor
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of checking if type is
datetime64[ns], check if it'snp.datetime64. We allow numpy datetime/timedelta objects with any unit to be converted toTimestampType.Why are the changes needed?
We are supposed to support this anyway, but pandas 3 now has a smart unit system for timestamps so more often than not the unit is not
ns.We still can't convert it back, but this is at least one-direction.
Does this PR introduce any user-facing change?
Not really other than some code that won't work would work now.
How was this patch tested?
Locally it was recognized.
Was this patch authored or co-authored using generative AI tooling?
No.