[SPARK-55240][CORE] Refactor LazyTry stacktrace handling to use wrapper instead of suppressed exception #54005
+38
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er instead of suppressed exception This PR refactors how `doTryWithCallerStacktrace` and `getTryWithCallerStacktrace` handle stacktrace stitching. Instead of adding an `OriginalTryStackTraceException` as a suppressed exception on the original exception, we now wrap the original exception inside `OriginalTryStackTraceException`. Key changes: - `OriginalTryStackTraceException` now wraps the original exception (as its cause) and stores the pre-computed "below" stacktrace portion - `doTryWithCallerStacktrace` returns `Failure(wrapper)` instead of modifying the original exception's suppressed list - `getTryWithCallerStacktrace` unwraps the original exception, stitches the stacktrace, and throws the original (not the wrapper) Benefits: - Cleaner exception output - no suppressed exceptions visible to users - Simpler code - no need to track first access or manage suppressed exception lifecycle - Original exception type is preserved when thrown
JIRA Issue Information=== Improvement SPARK-55240 === This comment was automatically generated by GitHub Actions |
|
cloud-fan
changed the title
Contributor
Author
|
This is kind of followup of #48882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors how
doTryWithCallerStacktraceandgetTryWithCallerStacktracehandle stacktrace stitching. Instead of adding anOriginalTryStackTraceExceptionas a suppressed exception on the original exception, we now wrap the original exception insideOriginalTryStackTraceException.Key changes:
OriginalTryStackTraceExceptionnow wraps the original exception (as its cause) and stores the pre-computed "below" stacktrace portiondoTryWithCallerStacktracereturnsFailure(wrapper)instead of modifying the original exception's suppressed listgetTryWithCallerStacktraceunwraps the original exception, stitches the stacktrace, and throws the original (not the wrapper)Why are the changes needed?
no suppressed exceptions visible to users
Does this PR introduce any user-facing change?
Yes, exceptions thrown from
LazyTry.getwill no longer have a suppressedOriginalTryStackTraceException. The stacktrace stitching behavior remains the same.How was this patch tested?
Existing unit tests in
UtilsSuiteandLazyTrySuiteupdated and passing.Was this patch authored or co-authored using generative AI tooling?
Yes.