Skip to content

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Jan 28, 2026

What changes were proposed in this pull request?

Tries to use a real module name in the test failure report instead of __main__.

Why are the changes needed?

In the test failure report, it uses __main__ as a module name after #53683.

======================================================================
FAIL [0.309s]: test_apply_batch_with_type (__main__.FrameApplyFunctionTests.test_apply_batch_with_type)
----------------------------------------------------------------------

It should be a real module name as before.

======================================================================
FAIL [0.322s]: test_apply_batch_with_type (pyspark.pandas.tests.computation.test_apply_func.FrameApplyFunctionTests.test_apply_batch_with_type)
----------------------------------------------------------------------

Does this PR introduce any user-facing change?

Yes, the test failure report will show a real module name.

How was this patch tested?

Manually.

Was this patch authored or co-authored using generative AI tooling?

Cursor (gpt-5.2-codex)

@github-actions
Copy link

JIRA Issue Information

=== Test SPARK-54906 ===
Summary: Unify entries for all tests
Assignee: Tian Gao
Status: Resolved
Affected: ["4.2.0"]


This comment was automatically generated by GitHub Actions

@ueshin
Copy link
Member Author

ueshin commented Jan 28, 2026

cc @gaogaotiantian

@ueshin ueshin changed the title [SPARK-54906][PYTHON][TESTS][FOLLOW_UP] Try to use a real module name instead of __main__ [SPARK-54906][PYTHON][TESTS][FOLLOWUP] Try to use a real module name instead of __main__ Jan 28, 2026
@gaogaotiantian
Copy link
Contributor

Ah, it's because we used to do a from ... import * so all the test cases so all the test cases are labelled with the module path. Yeah this is one way to do it. If tests passed I think it's good. Thanks!

@zhengruifeng
Copy link
Contributor

thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants