[SPARK-55279][SQL] Add sketch_funcs group for DataSketches SQL functions
#54061
+40
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Improvement SPARK-55279 === This comment was automatically generated by GitHub Actions |
yaooqinn
force-pushed
the
SPARK-55279-sketch-funcs-group
branch
from
5a52f4b to
3349dc5
Compare
dongjoon-hyun
changed the title
sketch_funcs group for DataSketches SQL functions
dongjoon-hyun
approved these changes
Jan 30, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn and @allisonwang-db .
cc @peter-toth
yaooqinn
force-pushed
the
SPARK-55279-sketch-funcs-group
branch
from
3349dc5 to
4c8b0c9
Compare
peter-toth
approved these changes
Jan 30, 2026
yaooqinn
force-pushed
the
SPARK-55279-sketch-funcs-group
branch
from
4c8b0c9 to
8cc53f4
Compare
All DataSketches-related expression functions should have their own 'sketch_funcs' group instead of being grouped under 'misc_funcs'. This improves consistency with how other specialized function categories are organized and makes the documentation clearer for users. Move all sketch-related expression functions from misc_funcs to sketch_funcs: - HLL sketch functions: hll_sketch_estimate, hll_union - Theta sketch functions: theta_sketch_estimate, theta_union, theta_difference, theta_intersection - KLL sketch functions: kll_sketch_to_string_*, kll_sketch_get_n_*, kll_sketch_get_rank_*, kll_sketch_get_quantile_*, kll_sketch_get_pmf_*, kll_sketch_get_cdf_*, kll_sketch_merge_* - Tuple sketch functions: tuple_sketch_* expression functions - ApproxTopK: approx_top_k_estimate Add sketch_funcs to the groups set in gen-sql-functions-docs.py. Note: Aggregate functions (like hll_sketch_agg, theta_sketch_agg, kll_sketch_agg_*, etc.) remain in 'agg_funcs'. This PR moves 34 DataSketches-related expression functions from misc_funcs to a dedicated sketch_funcs group. These 34 functions represent over 60% of all misc_funcs, making misc_funcs a catch-all bucket that reduces documentation clarity. By creating sketch_funcs, we achieve consistency with other specialized function groups (avro_funcs, json_funcs, csv_funcs, xml_funcs, etc.) and make it easier for users to discover and understand DataSketches functionality in Spark SQL. No functional changes. The only difference is in how functions are grouped in documentation. Existing tests. Yes, GitHub Copilot was used to assist with this change.
yaooqinn
force-pushed
the
SPARK-55279-sketch-funcs-group
branch
from
8cc53f4 to
bd8912a
Compare
Member
Author
|
Merged to master, thank you @allisonwang-db @dongjoon-hyun @peter-toth BTW, the test failure is irrelevant and I'm trying to fix it in #54072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
All DataSketches-related expression functions should have their own
sketch_funcsgroup instead of being grouped undermisc_funcs.Move all sketch-related expression functions from
misc_funcstosketch_funcs:hll_sketch_estimate,hll_uniontheta_sketch_estimate,theta_union,theta_difference,theta_intersectionkll_sketch_to_string_*,kll_sketch_get_n_*,kll_sketch_get_rank_*,kll_sketch_get_quantile_*,kll_sketch_get_pmf_*,kll_sketch_get_cdf_*,kll_sketch_merge_*tuple_sketch_*expression functionsapprox_top_k_estimateAdd
sketch_funcsto the groups set ingen-sql-functions-docs.py.Note: Aggregate functions (like
hll_sketch_agg,theta_sketch_agg,kll_sketch_agg_*, etc.) remain inagg_funcs.Why are the changes needed?
This PR moves 34 DataSketches-related expression functions from
misc_funcsto a dedicatedsketch_funcsgroup. These 34 functions represent over 60% of allmisc_funcs, makingmisc_funcsa catch-all bucket that reduces documentation clarity. By creatingsketch_funcs, we achieve consistency with other specialized function groups (avro_funcs,json_funcs,csv_funcs,xml_funcs, etc.) and make it easier for users to discover and understand DataSketches functionality in Spark SQL.Does this PR introduce any user-facing change?
No functional changes. The only difference is in how functions are grouped in documentation.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
Yes, GitHub Copilot was used to assist with this change.