[SPARK-54969][PYTHON] Implement new arrow->pandas conversion #54105
+210
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Sub-task SPARK-54969 === This comment was automatically generated by GitHub Actions |
zhengruifeng
force-pushed
the
convert_np
branch
from
f222c20 to
54f9f43
Compare
zhengruifeng
commented
Feb 3, 2026
| Converted pandas Series. If df_for_struct is True and the type is StructType, | ||
| returns a DataFrame with columns corresponding to struct fields. | ||
| """ | ||
| if cls._prefer_convert_numpy(target_type, df_for_struct): |
Contributor
Author
There was a problem hiding this comment.
our target is to replace convert_legacy with convert_numpy
Contributor
Author
|
cc @fangchenli and @Yicong-Huang the new conversion is to replace |
python/pyspark/sql/conversion.py
Outdated
| ), | ||
| ): | ||
| # TODO(ruifeng): revisit date_as_object | ||
| # TODO(ruifeng): implement coerce_temporal_nanoseconds |
Member
There was a problem hiding this comment.
Could you convert this to the community style, TODO(SPARK-XXX), instead of personal TODO style?
HyukjinKwon
approved these changes
Feb 3, 2026
Contributor
Author
|
thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement new arrow->pandas conversion
Why are the changes needed?
to replace existing conversion, based on my local test, the conversion of integers with nulls is 3x+ faster:
conversion used in
convert_legacynew conversion
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no