[SPARK-55337][SS] Fix MemoryStream backward compatibility #54108
+104
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Bug SPARK-55337 === This comment was automatically generated by GitHub Actions |
cloud-fan
force-pushed
the
memory-stream-compat
branch
from
9d29544 to
6074dff
Compare
cloud-fan
commented
Feb 3, 2026
|
|
||
| // Deprecated: Used when an implicit SQLContext is in scope | ||
| @deprecated("Use MemoryStream.apply with an implicit SparkSession instead of SQLContext", "4.1.0") | ||
| def apply[A: Encoder]()(implicit sqlContext: SQLContext): MemoryStream[A] = |
Contributor
Author
There was a problem hiding this comment.
This is the problem. This is not backward compatible, as the previous API is def apply[A: Encoder](implicit sqlContext: SQLContext): MemoryStream[A] (no parentheses).
There is no way to keep both implicits. So the proposal here is to only keep implicit SQLContext, and require to pass SparkSession implicitly.
cloud-fan
force-pushed
the
memory-stream-compat
branch
2 times, most recently
from
5825d62 to
14f1f0f
Compare
Contributor
Author
dongjoon-hyun
previously requested changes
Feb 3, 2026
Member
There was a problem hiding this comment.
@cloud-fan , we cannot create a follow-up for the released JIRA issue because your PR has a different fix version, 4.1.2 (or 4.2.0), instead of 4.1.0. Please create a new JIRA ID.
cloud-fan
changed the title
### What changes were proposed in this pull request? This is a followup to apache#52402 that addresses backward compatibility concerns: 1. Keep the original `implicit SQLContext` factory methods for full backward compatibility 2. Add new overloads with explicit `SparkSession` parameter for new code 3. Fix `TestGraphRegistrationContext` to provide implicit `spark` and `sqlContext` to avoid name shadowing issues in nested classes 4. Remove redundant `implicit val sparkSession` declarations from pipeline tests that are no longer needed with the fix ### Why are the changes needed? PR apache#52402 changed the MemoryStream API to use `implicit SparkSession` which broke backward compatibility for code that only has `implicit SQLContext` available. This followup ensures: - Old code continues to work without modification - New code can use SparkSession with explicit parameters - Internal implementation uses SparkSession (modernization from apache#52402) ### Does this PR introduce _any_ user-facing change? No. This maintains full backward compatibility while adding new API options. ### How was this patch tested? Existing tests pass. The API changes are additive. ### Was this patch authored or co-authored using generative AI tooling? Yes Co-authored-by: Cursor <cursoragent@cursor.com>
cloud-fan
force-pushed
the
memory-stream-compat
branch
from
14f1f0f to
823133a
Compare
Member
|
Thank you for getting a new JIRA ID. |
Remove the `apply[A: Encoder](numPartitions: Int, sparkSession: SparkSession)` factory method that creates a semantic trap - it can accidentally match calls like `MemoryStream[T](0, spark)` interpreting the first argument as `numPartitions` instead of `id`, causing zero partitions to be created and no data to flow. Users who need both `numPartitions` and explicit `SparkSession` can use the case class constructor directly: `new MemoryStream[A](id, sparkSession, Some(numPartitions))`. Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup to #52402 that addresses backward compatibility concerns:
implicit SQLContextfactory methods for full backward compatibilitySparkSessionparameter for new codeTestGraphRegistrationContextto provide implicitsparkandsqlContextto avoid name shadowing issues in nested classesimplicit val sparkSessiondeclarations from pipeline tests that are no longer needed with the fixWhy are the changes needed?
PR #52402 changed the MemoryStream API to use
implicit SparkSessionwhich broke backward compatibility for code that only hasimplicit SQLContextavailable. This followup ensures:Does this PR introduce any user-facing change?
No. This maintains full backward compatibility while adding new API options.
How was this patch tested?
Existing tests pass. The API changes are additive.
Was this patch authored or co-authored using generative AI tooling?
Yes
Made with Cursor