[MINOR][Geo][SQL] Remove redundant Geo case in XML data source #54116
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following up on the original PR for disallowing Geo types in all file-based data sources except Parquet (#54038), this minor PR removes the redundant case from XML file format.
Why are the changes needed?
The explicit case for
GeometryTypeandGeographyTypereturning false is unnecessary here since the default case already handles all unsupported types at this moment. Also, XML is generally governed by XSD (XML Schema Definition), which does not include geospatial types as part of its standard type system at all, so there's no need to explicitly exclude them.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests suffice.
Was this patch authored or co-authored using generative AI tooling?
No.