[SPARK-55383][INFRA] Only send test report to codecov in coverage run#54168
Open
gaogaotiantian wants to merge 3 commits intoapache:masterfrom
Open
[SPARK-55383][INFRA] Only send test report to codecov in coverage run#54168gaogaotiantian wants to merge 3 commits intoapache:masterfrom
gaogaotiantian wants to merge 3 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Improvement SPARK-55383 === This comment was automatically generated by GitHub Actions |
Contributor
|
need coverage back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of trying to send test report on all main branch commits, we only send it for coverage run.
Also removed an unused coverage token.
Why are the changes needed?
We tried the test dashboard of codecov - https://app.codecov.io/github/apache/spark/tests but it's not super great.
However it's not completely useless. The average time of tests actually helps us to locate slowest tests. It does not mess up with coverage report, as long as for each commit we have both the coverage report and test report.
So, we can do a report only on coverage run - single report each day for both coverage and test speed.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI should pass, hopefully coverage can recover.
Was this patch authored or co-authored using generative AI tooling?
No.