Skip to content

Conversation

@gaogaotiantian
Copy link
Contributor

What changes were proposed in this pull request?

  • Add all dangling test files to modules.py
  • There are two helper python files that start with test_ which is a semantics used for python test files. Rename those files and change the caller code accordingly.

Why are the changes needed?

We should run tests if they were there.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

Was this patch authored or co-authored using generative AI tooling?

No

@gaogaotiantian
Copy link
Contributor Author

Interesting, the test is actually failing. I will add the passing test first. Then for each failing test, I'll add it with the fix to the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants