[SPARK-55561][SS] Add retries for all Kafka admin client methods#54339
Open
kavpreetgrewal wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55561][SS] Add retries for all Kafka admin client methods#54339kavpreetgrewal wants to merge 2 commits intoapache:masterfrom
kavpreetgrewal wants to merge 2 commits intoapache:masterfrom
Conversation
brkyvz
reviewed
Feb 17, 2026
Contributor
brkyvz
left a comment
brkyvz
left a comment
There was a problem hiding this comment.
Thanks for the fix! Can we add a unit test for this through mocking?
Contributor
Author
|
@brkyvz added 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
KafkaOffsetReaderAdmin.fetchPartitionOffsetswithwithRetrieswithRetriesto work with generic types rather than justMap[TopicPartition, Long]Why are the changes needed?
In
KafkaOffsetReaderAdmin.fetchPartitionOffsets, method calls using the admin client are not retried, unlike other calls with are wrapped withwithRetries. These calls should also be retried so that we handle transient errors gracefully and do not immediately fail the stream.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added new unit tests and existing tests should continue to pass.
Ran tests locally:
build/sbt "sql-kafka-0-10/testOnly org.apache.spark.sql.kafka010.KafkaOffsetReaderSuite"Was this patch authored or co-authored using generative AI tooling?