[MINOR][PYTHON] Add asv in dev/requirements.txt#54530
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[MINOR][PYTHON] Add asv in dev/requirements.txt#54530zhengruifeng wants to merge 2 commits intoapache:masterfrom
asv in dev/requirements.txt#54530zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
dongjoon-hyun
approved these changes
Feb 27, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you add the direction that how to run the benchmark locally, @zhengruifeng ?
HyukjinKwon
approved these changes
Feb 27, 2026
Contributor
Author
|
thanks, merged to master |
Member
Gentle ping once more, @zhengruifeng . I thought you were going to add something like the following to the PR description. |
Member
|
Maybe, pointing to |
Contributor
Author
|
@dongjoon-hyun sorry, I missed the comment. Sounds good, let me add direction on how to run a separate benchmark in |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 27, 2026
### What changes were proposed in this pull request? Document how to run a specified benchmark ### Why are the changes needed? to address #54530 (comment) ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes #54536 from zhengruifeng/doc_how_separate_benchmark. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
asvindev/requirements.txtWhy are the changes needed?
asvis used to run the benchmark locallyDoes this PR introduce any user-facing change?
no, dev-only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no