[SPARK-55794][SQL] Always alias OuterReferences#54576
Closed
mihailotim-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55794][SQL] Always alias OuterReferences#54576mihailotim-db wants to merge 1 commit intoapache:masterfrom
OuterReferences#54576mihailotim-db wants to merge 1 commit intoapache:masterfrom
Conversation
5c9c9a7 to
1a995b3
Compare
1a995b3 to
3df9592
Compare
dtenedor
approved these changes
Mar 2, 2026
Contributor
dtenedor
left a comment
There was a problem hiding this comment.
Looks good, thanks for making the behavior converge between the analyzers.
Contributor
|
LGTM, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose that we always alias
OuterReferencesWhy are the changes needed?
These changes are needed for 2 main reasons: provide avoid potential issues with exposing raw outer references and their expressions ids and provide compatibility between fixed-point and single-pass analyzers.
For example, in a query like:
before this change, the output will be:
The output of the subquery is now exactly the same as the one from outer reference (
x#1). This can potentially cause query failures or correctness issues, but at the moment only presents as a compatibility issue between fixed-point and single-pass analyzersDoes this PR introduce any user-facing change?
No
How was this patch tested?
Added new test cases + existing tests
Was this patch authored or co-authored using generative AI tooling?
No