Skip to content

[SPARK-55492][SQL][SS][FOLLOWUP] Clarify error message; do not use non-local return#54583

Closed
fedimser wants to merge 2 commits intoapache:masterfrom
fedimser:fix-10
Closed

[SPARK-55492][SQL][SS][FOLLOWUP] Clarify error message; do not use non-local return#54583
fedimser wants to merge 2 commits intoapache:masterfrom
fedimser:fix-10

Conversation

@fedimser
Copy link
Contributor

@fedimser fedimser commented Mar 3, 2026

What changes were proposed in this pull request?

  1. Changed error message to make it more clear and suggest resolution.
  2. Do not use non-local return in a closure.

This is a follow-up on #54254.

Why are the changes needed?

To make error message more informative and avoid a bug-prone pattern.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@fedimser fedimser changed the title [MINOR] [MINOR] Clarify error message; do not use non-local return Mar 3, 2026
@HeartSaVioR
Copy link
Contributor

Let's use the pattern of [SPARK-XXXXX][<areas>...][FOLLOWUP] to track the change better.

@HeartSaVioR HeartSaVioR changed the title [MINOR] Clarify error message; do not use non-local return [SPARK-55492][SQL][SS][FOLLOWUP] Clarify error message; do not use non-local return Mar 3, 2026
@fedimser fedimser marked this pull request as ready for review March 3, 2026 01:53
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending CI

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants