[SPARK-55771][UI][FOLLOWUP] Fix progress bar height alignment in BS5 stacked progress#54587
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55771][UI][FOLLOWUP] Fix progress bar height alignment in BS5 stacked progress#54587yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn wants to merge 1 commit intoapache:masterfrom
Conversation
…stacked progress The inner .progress divs inside .progress-stacked use BS5's default height (1rem/14px) which is shorter than the stacked container's custom height (1.42rem/20px), causing visual misalignment. Add height: 100% to make inner progress bars fill the parent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
cc @pan3793
|
pan3793
approved these changes
Mar 3, 2026
Member
pan3793
left a comment
pan3793
left a comment
There was a problem hiding this comment.
manually verified, looks correct to me.
Member
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the height mismatch between
.progress-stackedcontainer (1.42rem) and its inner.progressdivs (BS5 default 1rem) by addingheight: 100%to the inner.progresselements.Why are the changes needed?
After SPARK-55771 introduced BS5
.progress-stacked, the inner.progressbars use Bootstrap 5's default height (1rem ≈ 14px) which is shorter than the custom stacked container height (1.42rem ≈ 20px). This causes the colored progress bars to not fill the full height of the container, creating a visual misalignment.Before (misaligned — bar shorter than container):
Inner
.progress= 14px, container = 20pxAfter (aligned — bar fills container):
Inner
.progress= 100% = 20px, container = 20pxDoes this PR introduce any user-facing change?
Visual fix only — progress bars now properly fill their container height.
How was this patch tested?
Manual verification with Playwright — confirmed all three elements (
.progress-stacked,.progress,.progress-bar) now render at the same height (20px).